Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cache): adds option to compress the cache file #860

Merged
merged 3 commits into from
Nov 5, 2023

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Nov 4, 2023

Description

  • adds an option to compress the cache file
  • 🏕️ some updates in the cache typing

Motivation and Context

The cache file can become quite large. The cache file is also very compressible (both gzip and brotli reduce the file size to 10% of the original or less). My original hunch was that as less i/o is needed this might constitute a net performance gain for large enough code bases. I haven't been able to substantiate that with evidence, though.

However, I decided to still let this in because:

  • when you switch compression on, it (only) adds a few milliseconds to the total execution time
  • the resulting file is so much smaller, that the trade-off of the few extra milliseconds might be worth it for other reasons

How Has This Been Tested?

  • green ci
  • additional automated tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

Copy link

codeclimate bot commented Nov 5, 2023

Code Climate has analyzed commit 40e071b and detected 0 issues on this pull request.

View more on Code Climate.

@sverweij sverweij merged commit 2868e19 into main Nov 5, 2023
7 checks passed
@sverweij sverweij deleted the feature/zip-the-cache branch November 5, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant